-
-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace aiohttp mock with patch in Advantage Air #104932
Conversation
I have reverted my last two commits as I cannot figure out how to get that to work. |
I'm not sure what you reverted since you force pushed. Is there something specific you need help getting to work? |
If the PR is acceptable as is, I'd prefer to get this merged, as it's holding up a bug fix now (is going to require a test rewrite which this PR has achieved). I tried putting my fixtures in the common.py but the auto formatting automatically removed the imports. I'll give it another go once I've got the other issue sorted. |
@Bre77 I cleaned up the duplicate code a bit for you. Feel free to revert my change if that's not what you wanted. |
Happy to merge this as-is unless you want to clean it up more |
Its passing, so I am happy. Merge away. Thanks for doing this! Is "conftest.py" a special filename that gets imported by pytest? Thats the part I couldnt figure out. |
Proposed change
Completely removes aiohttp mock from tests, and replaces with patch.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: